Skip to content

Coordinator fix logging #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnovais merged 3 commits into from
Jan 15, 2025
Merged

Coordinator fix logging #551

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c088df6
coordinator: fix log level in coordinator
jpnovais Jan 14, 2025
831c5f3
coordinator: fix log level in coordinator
jpnovais Jan 14, 2025
dd54ac6
coordinator: fix log level in coordinator
jpnovais Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .../consensys/zkevm/ethereum/coordination/conflation/ProofGeneratingConflationHandlerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,20 @@ class ProofGeneratingConflationHandlerImpl(
vertx = vertx,
backoffDelay = config.conflationAndProofGenerationRetryInterval,
exceptionConsumer = {
log.error("Conflation and proof creation flow failed!", it)
// log failure as warning, but keeps on retrying...
log.warn(
"conflation and proof creation flow failed batch={} errorMessage={}",
blockIntervalString,
it.message
)
}
) {
conflationToProofCreation(conflation)
}
}.getOrElse { error -> SafeFuture.failedFuture<Unit>(error) }
.whenException { th ->
log.error(
"Traces conflation or proof failed: batch={} errorMessage={}",
"traces conflation or proof request failed: batch={} errorMessage={}",
blockIntervalString,
th.message,
th
Expand All @@ -60,8 +65,8 @@ class ProofGeneratingConflationHandlerImpl(
return tracesProductionCoordinator
.conflateExecutionTraces(blockNumbersAndHash)
.whenException { th ->
log.error(
"Traces conflation failed: batch={} errorMessage={}",
log.debug(
"traces conflation failed: batch={} errorMessage={}",
conflation.conflationResult.intervalString(),
th.message,
th
Expand All @@ -79,7 +84,7 @@ class ProofGeneratingConflationHandlerImpl(
log.info("execution proof generated: batch={}", blockIntervalString)
}
.whenException { th ->
log.error(
log.debug(
"execution proof failure: batch={} errorMessage={}",
blockIntervalString,
th.message,
Expand Down