Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved transaction finality time #286

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Improved transaction finality time #286

merged 7 commits into from
Oct 12, 2022

Conversation

Anachor
Copy link
Contributor

@Anachor Anachor commented Oct 5, 2022

Improved the txn finality time by decrease block time to 4 sec. To preserve tps, transactions per block was reduced to 800.

  • Added targetTransactionPerBlock field in BlockchainConfig
  • Implemented _UpdateConfigToV16()
  • Used targetTransactionPerBlock from config instead of hardcoded value in BlockProducer.cs

Copy link
Contributor

@sgladkov sgladkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 small comments, but it looks good to me

src/Lachain.Core/Config/ConfigManager.cs Outdated Show resolved Hide resolved
src/Lachain.Core/Consensus/BlockProducer.cs Outdated Show resolved Hide resolved
@Anachor
Copy link
Contributor Author

Anachor commented Oct 6, 2022

Updated code addressing @sgladkov 's comments.

sgladkov
sgladkov previously approved these changes Oct 6, 2022
src/Lachain.Core/Config/ConfigManager.cs Outdated Show resolved Hide resolved
src/Lachain.Core/Consensus/BlockProducer.cs Outdated Show resolved Hide resolved
@sgladkov sgladkov merged commit babd752 into dev Oct 12, 2022
@sgladkov sgladkov deleted the improve-finality branch October 12, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants