New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_segments optimization #258

Open

lucasgautheron opened this issue Jul 20, 2021 · 0 comments

Assignees

Labels

enhancement performance

Collaborator

lucasgautheron commented Jul 20, 2021

Is your feature request related to a problem? Please describe.

get_segments becomes really slow as the amount of annotation segments gets large. most of the work is probably done by clip_segments.

Describe the solution you'd like

traverse segments only once rather than once per annotation segment
maybe us multithreading if necessary
keep things vectorised...
do proper benchmarks (and a bit of profiling to make sure the issue is really clip_segments)

lucasgautheron added the enhancement label

lucasgautheron self-assigned this

lucasgautheron added the performance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment