Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default #1213

Open
leiserfg opened this issue Jul 17, 2024 · 3 comments
Open

Override default #1213

leiserfg opened this issue Jul 17, 2024 · 3 comments

Comments

@leiserfg
Copy link
Contributor

Hi @L3MON4D3 I saw this in @tjdevries config, should we upstream it?
(In that case it will be the first real "push requests" in history 😄 )

https://github.com/tjdevries/config.nvim/blob/c16bab0565253f862da0cef6a288399640b3c567/lua/custom/snippets.lua#L41

@L3MON4D3
Copy link
Owner

override_builtin doesn't mean anything to me, am I missing something? 😅 (I'm assuming I am, please educate me :D)

@leiserfg
Copy link
Contributor Author

That single line is incorrect, but the rest of the file is replacing the built-in snippets of vim. So my guess is that that's the API @tjdevries was expecting for that same usecase.

@L3MON4D3
Copy link
Owner

Ahh I see..
Yeah that seems like a good idea, quickly swap out snippet engines, and hooking vim.*-functions is very well-known. I like it :)

I'd like to mention that implementing this as a simple api-function would work as well, but is probably more cumbersome for the user (setting .setup({...})-values can be done in the lazy-configuration directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants