Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of times with minutes #131

Open
dperelman opened this issue Jun 23, 2024 · 1 comment
Open

Naming of times with minutes #131

dperelman opened this issue Jun 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dperelman
Copy link

I'm making a timelapse from a directory where I have an autosave every 5 minutes, and the labels are weird (2-1h, 2-2h, 2-3h, ..., 13-1h, 13-2h, ... 13-12h). Reading some other comments, it sounds like the format "H:num h" where H is the number of hours the save has been played and num is just an incrementing number.

I manually hacked in a change to instead display H:m:s (hours, minutes, and seconds the save has been played) which makes more sense for the data I have (although the seconds should be omitted).

I also would like to display the realtime day (maybe once when the day changes to be less noisy), but it looks like the system currently doesn't keep track of that (i.e. the mtime of the save file).

As I said, I did hack in something sorta like what I want, so I will look into making a PR of a cleaner version, maybe with an option for different formatting of how to label the saves in the display.

@L0laapk3 L0laapk3 added the enhancement New feature or request label Jun 24, 2024
@dperelman
Copy link
Author

dperelman commented Jun 30, 2024

I have a version doing everything I want including this in my fork: https://github.com/dperelman/FactorioMaps. The commit that implements this specific change is b6f53c8. As it decouples the display name from the path, it could be pretty easily modified to show anything as the name, including reverting to the current behavior (possibly reading a setting from mapInfo.json given on the command-line to auto.py?). For example, 9037992 uses the data I added to mapInfo.json in 8d65be1 to display the date of the save as well.

I can make a PR (or you can just cherry-pick my commits), but I wasn't sure how this would interact with the dev branch I saw you had. (I tried using it, but it was much slower (maybe because it was including the entire explored map, which I think is a bug) and I have a lot of saves.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants