Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViaFacet.Chat causing broken translation keys for newer clients #137

Open
Pugzy opened this issue Jul 10, 2023 · 0 comments
Open

ViaFacet.Chat causing broken translation keys for newer clients #137

Pugzy opened this issue Jul 10, 2023 · 0 comments

Comments

@Pugzy
Copy link

Pugzy commented Jul 10, 2023

When sending item names on a 1.8 server as translatable components to players on 1.13+ such as "item.swordStone.name" the translatable key doesn't get migrated with viaversion before getting sent to the client.

It's sent as {"translate":"item.swordStone.name"} which the client displays as item.swordStone.name in chat.

This only happens when sent with the ViaFacet but if its sent with the CraftBukkitFacet ViaVersions converts the component keys and it displays correctly.

ViaFacet is using ProtocolBased which injects in to ViaVersion "1_16", "1_15_2" to do the hex color stuff but this causes the message to skip the 1.8 to 1.15.2 packet translations steps.

Spoke briefly with @KingOfSquares and @Electroid about this in the past who may be able to advise further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant