Skip to content

Add Typescript definitions #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kureev merged 3 commits into from
Aug 7, 2017
Merged

Add Typescript definitions #225

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d818985
Add Typescript definitions
ahanriat Aug 1, 2017
3d5391f
Fix typescript definition
Bhullnatik Aug 2, 2017
675970e
Merge pull request #1 from Bhullnatik/patch-1
ahanriat Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import * as React from 'react';
import { ViewProperties } from 'react-native';

export interface BlurViewProperties {
blurType: 'xlight' | 'light' | 'dark'
// tvOS only
| 'extraDark' | 'regular' | 'prominent';
blurAmount?: number; // 0 - 100

@Kureev Kureev Aug 2, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more precise about the range?

@ahanriat ahanriat Aug 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kureev, the only possible way to do it currently would be to have a enum like:

blurAmount?: 0 | 1 | 2 | 3 | ... | 99 | 100;

This issue on Typescript is exactly what we are looking for, but it looks like there is currently no clean way to do it, appart using an enum microsoft/TypeScript#15480 👀

@Kureev Kureev Aug 7, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it! Thanks for the insight! Then I think it isn't a problem

@arnibarnason arnibarnason Aug 9, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't viewRef be in there as well?

@ahanriat ahanriat Aug 14, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnibarnason doesn't the extends React.Component does this?

style?: ViewProperties;
}

export class BlurView extends React.Component<BlurViewProperties, {}> {}


export interface VibrancyViewProperties extends BlurView {}

export class VibrancyView extends React.Component<BlurViewProperties, {}> {}