Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KHR_material_cmnBlinnPhong extension #83

Closed
Kupoman opened this issue Aug 16, 2017 · 4 comments
Closed

Add support for KHR_material_cmnBlinnPhong extension #83

Kupoman opened this issue Aug 16, 2017 · 4 comments

Comments

@Kupoman
Copy link
Owner

Kupoman commented Aug 16, 2017

There is a discussion on the extension here: KhronosGroup/glTF#947
And a pull request here: KhronosGroup/glTF#1075

@Kupoman Kupoman added this to the 1.1 milestone Aug 16, 2017
@Kupoman Kupoman removed this from the 1.1 milestone Aug 26, 2017
@Kupoman
Copy link
Owner Author

Kupoman commented Aug 26, 2017

Removing from version 1.1 targets since the extension is not yet complete.

@Kupoman Kupoman added this to the v1.2 milestone Sep 5, 2017
@Moguri Moguri removed this from the v1.2 milestone Oct 16, 2017
@Moguri
Copy link
Collaborator

Moguri commented Oct 16, 2017

Clearing the milestone on this until the spec is more stable/finalized.

@Kupoman Kupoman added this to the Unscheduled milestone Nov 10, 2017
@donmccurdy
Copy link
Contributor

donmccurdy commented Feb 20, 2018

An update — KHR_materials_common and its proposed alternative, KHR_materials_cmnBlinnPhong, will not be created for glTF 2.0 at this time.

The strongest feedback from the community was around shadeless materials, so we are moving forward with the simpler KHR_materials_unlit:

The extension is not yet ratified, but Sketchfab and Facebook will begin using it shortly and the schema is unlikely to change — I think it would be safe to include with the next milestone here, and I have also proposed it for the Khronos exporter.

@Kupoman
Copy link
Owner Author

Kupoman commented Mar 3, 2018

Closing this issue since this extension is unlikely to go anywhere. Thanks for the update @donmccurdy.

@Kupoman Kupoman closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants