Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaBundle] Fix thumbnail image URLs #3299

Open
jerome2710 opened this issue Jul 11, 2023 · 2 comments
Open

[MediaBundle] Fix thumbnail image URLs #3299

jerome2710 opened this issue Jul 11, 2023 · 2 comments

Comments

@jerome2710
Copy link

Can we fix the thumbnail image URLs? The macro is currently not spaceless, returning a mark-up. YouTube videos don't have an asset and result in a broken image: https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/6.x/src/Kunstmaan/MediaBundle/Resources/views/Form/formWidgets.html.twig#L76

Before:

Scherm­afbeelding 2023-07-11 om 10 27 19

After:

{% set imageUrl = _self.getImageUrl(media, 'media_list_thumbnail')|spaceless %}
{% set retinaImageUrl = _self.getImageUrl(media, 'media_list_thumbnail_retina')|spaceless %}

Scherm­afbeelding 2023-07-11 om 10 27 34

@tarjei
Copy link
Contributor

tarjei commented Jun 26, 2024

@jerome2710 maybe just submit a quick PR for this?

@jerome2710
Copy link
Author

jerome2710 commented Jun 26, 2024

@jerome2710 maybe just submit a quick PR for this?

@tarjei, will do! I'm currently on vacation, I'll set a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants