Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace controller extends to AbstractController #2938

Closed
acrobat opened this issue Sep 9, 2021 · 0 comments · Fixed by #2946
Closed

Replace controller extends to AbstractController #2938

acrobat opened this issue Sep 9, 2021 · 0 comments · Fixed by #2946

Comments

@acrobat
Copy link
Member

acrobat commented Sep 9, 2021

The symfony Controller class is deprecated and will be replace by AbstractController. So following classes need to be updated to be compatible with symfony 5.

Possible solutions:

  • Classes with no uses of $this->get() to access the container can be changed to extended from the class.
  • Other (larger) controller classes that use the container should be refactored that the common logic is moved to a service and should be declared final. This way we can change the extended class without BC breaks in 6.0
    Quick fix can be the already tag them as @final so we can move on and do the refactoring in later version of 6.x
  • The "special" controllers like AdminListController, AbstractXXXControllers can't be final so they will need a deprecation that accessing the container directly will not work in 6.0
Class Status
src/Kunstmaan/AdminBundle/Controller/BaseSettingsController.php
src/Kunstmaan/AdminBundle/Controller/DefaultController.php
src/Kunstmaan/AdminBundle/Controller/ModulesController.php
src/Kunstmaan/AdminListBundle/Controller/AdminListController.php
src/Kunstmaan/AdminListBundle/Controller/EntityLockCheckController.php
src/Kunstmaan/ArticleBundle/Controller/AbstractArticleOverviewPageController.php
src/Kunstmaan/CacheBundle/Controller/VarnishController.php
src/Kunstmaan/DashboardBundle/Controller/DashboardController.php
src/Kunstmaan/DashboardBundle/Controller/GoogleAnalyticsAJAXController.php
src/Kunstmaan/DashboardBundle/Controller/GoogleAnalyticsController.php
src/Kunstmaan/FormBundle/Controller/AbstractFormPageController.php
src/Kunstmaan/FormBundle/Controller/FormSubmissionsController.php
src/Kunstmaan/LeadGenerationBundle/Controller/AbstractNewsletterController.php
src/Kunstmaan/LeadGenerationBundle/Controller/AbstractRedirectController.php
src/Kunstmaan/MediaBundle/Controller/AviaryController.php
src/Kunstmaan/MediaBundle/Controller/ChooserController.php
src/Kunstmaan/MediaBundle/Controller/FolderController.php
src/Kunstmaan/MediaBundle/Controller/IconFontController.php
src/Kunstmaan/MediaBundle/Controller/MediaController.php
src/Kunstmaan/MultiDomainBundle/Controller/SiteSwitchController.php
src/Kunstmaan/NodeBundle/Controller/NodeAdminController.php
src/Kunstmaan/NodeBundle/Controller/SlugController.php
src/Kunstmaan/NodeBundle/Controller/WidgetsController.php
src/Kunstmaan/NodeSearchBundle/Controller/AbstractSearchPageController.php
src/Kunstmaan/PagePartBundle/Controller/PagePartAdminController.php
src/Kunstmaan/SeoBundle/Controller/RobotsController.php
src/Kunstmaan/SitemapBundle/Controller/SitemapController.php
src/Kunstmaan/TranslatorBundle/Controller/TranslatorCommandController.php
src/Kunstmaan/VotingBundle/Controller/VotingController.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant