Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Defaults #490

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add tests for Defaults #490

merged 2 commits into from
Aug 1, 2024

Conversation

averevki
Copy link
Contributor

Changes

  • Add the Defaults&Overrides interface to the testsuite
  • Add tests for the Defaults

Closes #375

@martinhesko
Copy link
Contributor

Already reviewed in the previous PR, LGTM

martinhesko
martinhesko previously approved these changes Jul 23, 2024
View reviewed changes
@averevki averevki force-pushed the defaults-tests branch 2 times, most recently from 681001b to 664e73a Compare July 24, 2024 09:21
@averevki
Copy link
Contributor Author

signoff commits^

martinhesko
martinhesko previously approved these changes Jul 24, 2024
View reviewed changes
@averevki
Add tests for defaults
fd37511 
Signed-off-by: averevki <[email protected]>
@averevki averevki merged commit 98c5cfb into Kuadrant:main Aug 1, 2024
3 checks passed
@averevki averevki mentioned this pull request Aug 27, 2024
Merged
@averevki averevki deleted the defaults-tests branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmolar jsmolar jsmolar left review comments

@pehala pehala pehala approved these changes

@martinhesko martinhesko martinhesko approved these changes

@azgabur azgabur Awaiting requested review from azgabur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atomic defaults tests
4 participants
@averevki @martinhesko @pehala @jsmolar