Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable image via spec #93

Closed
wants to merge 1 commit into from
Closed

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Aug 16, 2023

Resolves #78

@KevFan KevFan force-pushed the image branch 2 times, most recently from 0c1b7a3 to 313c706 Compare August 16, 2023 11:01
@KevFan KevFan added kind/enhancement New feature or request participation/good first issue Good for newcomers status/blocked area/api CRD or other public API related labels Aug 30, 2023
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
api/v1alpha1/limitador_types.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #93 (766cb00) into main (fdb0c52) will increase coverage by 1.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   52.24%   53.50%   +1.25%     
==========================================
  Files          12       11       -1     
  Lines         867      884      +17     
==========================================
+ Hits          453      473      +20     
+ Misses        374      372       -2     
+ Partials       40       39       -1     
Flag Coverage Δ
integration 53.84% <100.00%> (+0.14%) ⬆️
unit 53.32% <100.00%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <100.00%> (ø)
pkg/helpers (u) 9.75% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 29.38% <100.00%> (+2.78%) ⬆️
pkg/limitador (u) 72.87% <100.00%> (+0.85%) ⬆️
controllers (i) 53.84% <100.00%> (+0.14%) ⬆️
Files Changed Coverage Δ
api/v1alpha1/limitador_types.go 100.00% <100.00%> (ø)
controllers/limitador_controller.go 46.69% <100.00%> (+0.25%) ⬆️
pkg/limitador/k8s_objects.go 72.87% <100.00%> (+1.14%) ⬆️
pkg/reconcilers/deployment.go 29.62% <100.00%> (+7.71%) ⬆️

@KevFan
Copy link
Contributor Author

KevFan commented Sep 19, 2023

Closing this as we've decided against allowing this directly in the spec as this is mainly a developer / testing configuration. Will create an RFC to decide the best way to allow for this via some other means rather than directly through the CRD spec

@KevFan KevFan closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api CRD or other public API related kind/enhancement New feature or request participation/good first issue Good for newcomers status/blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production-ready: Configure possible different Image
3 participants