Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Unit-tests for common/common.go (part 3 of 3) #186

Merged

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    33584b8 View commit details
    Browse the repository at this point in the history
  2. test: Add two FAILING unit-tests for UnMarshallLimitNamespace (#167)

    The two failing test cases include:
    - when namespace has no gateway name then return an error
    - when namespace has no domain name then return an error
    
    In these test-cases we leave the separator (either "/" or "#"), which causes the function to return an error when the gateway name or domain name is missing. In the last two test cases:
    - when namespace only has gateway name (missing 'namespace/') and domain then return an error
    - when namespace only has namespace name (missing '/gwName') and domain then return an error
    the separator (/) is missing along with the namespace or gateway names, causing the function to return the correct error message.
    art-tapin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8b044ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bf8769 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ba535d3 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Configuration menu
    Copy the full SHA
    6fbb65d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49a9f8e View commit details
    Browse the repository at this point in the history
  3. [test] Optimizations, improvements, and unit tests for common/common.…

    …go (part 2 of 3) (#182)
    
    * test: Add unit-tests for Contains (#167)
    
    * refactor: Add comment to Contains (#167)
    
    * test: Add unit-tests for Map (#167)
    
    * refactor: Add comment to Map (#167)
    
    * refactor: Add names to Map test cases (#167)
    
    * test: Add unit-tests for SliceCopy (#167)
    
    * refactor: Add comment to SliceCopy (#167)
    
    * test: Add unit-tests for ReverseSlice (#167)
    
    * refactor: Add comment to ReverseSlice (#167)
    
    * test: Add unit-tests for MergeMapStringString (#167)
    
    * refactor: Add missing import 'reflect'
    art-tapin authored May 10, 2023
    Configuration menu
    Copy the full SHA
    dcad23a View commit details
    Browse the repository at this point in the history
  4. fix: Ensure Istio gateways created in the tests are ready ('Programme…

    …d') by setting ClusterIP service type (#185)
    guicassolato authored May 10, 2023
    Configuration menu
    Copy the full SHA
    4f9ed21 View commit details
    Browse the repository at this point in the history
  5. changelog (#184)

    eguzki authored May 10, 2023
    Configuration menu
    Copy the full SHA
    e22eff6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Configuration menu
    Copy the full SHA
    8500ffb View commit details
    Browse the repository at this point in the history
  2. test: Add two test-cases for UnMarshallObjectKey (#167)

    1. when valid namespace and empty name (strKey ends with '/') then return valid ObjectKey with namespace only
    2. when valid name and empty namespace (strKey starts with '/') then return valid ObjectKey with name only
    
    Changes were discussed here: #187 (comment)
    art-tapin committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7c6e1df View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. test: Delete test case for UnMarshallLimitNamespace

    The test case "when namespace has no gateway name then return an error" has been removed from the test suite for UnMarshallLimitNamespace. This test case was tightly connected to the implementation of UnMarshallObjectKey, making it impossible to properly test the desired behavior in the context of UnMarshallLimitNamespace.
    art-tapin committed May 16, 2023
    Configuration menu
    Copy the full SHA
    426e868 View commit details
    Browse the repository at this point in the history
  2. refactor: Add clarity to the test name

    Describing the '/' separator as a default one we show that it is a default constant value.
    art-tapin committed May 16, 2023
    Configuration menu
    Copy the full SHA
    700a30c View commit details
    Browse the repository at this point in the history