Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[state-of-the-world] common policy status controller #730

Open
eguzki opened this issue Jul 4, 2024 · 4 comments · May be fixed by #994
Open

[state-of-the-world] common policy status controller #730

eguzki opened this issue Jul 4, 2024 · 4 comments · May be fixed by #994
Assignees
Labels
area/api Changes user facing APIs kind/enhancement New feature or request participation/help wanted Extra attention is needed size/medium

Comments

@eguzki
Copy link
Contributor

eguzki commented Jul 4, 2024

When dependent CRDs do not exist, some controllers are disabled. Currently controller-runtime panics when a controller watches a not existing type. When the controllers are disabled, they cannot report on the status of the policies. The only "error message" would be available in the operator logs.

This controller would update the status of the policies with understandable message when dependent types (CRDs) are not available. Some uses cases:

  • TLSPolicy → depends on the cert-manager CRDs (this PR adds watchers on cert-manager types)
  • RLP, auth, tls, dns policies → when GatewayAPI provider is not found → report in status. (like it is being done with the Kuadrant CRD)

Example of how an instance of the TLSPolicy status would look like when cert-manager would not be installed.

conditions:
  - lastTransitionTime: "2024-07-04T08:02:09Z"
    message: 'TLSPolicy has encountered some issues: cert-manager APIs not available'
    reason: Unknown
    status: "False"
    type: Accepted
observedGeneration: 1
@eguzki eguzki added kind/enhancement New feature or request participation/help wanted Extra attention is needed size/medium area/api Changes user facing APIs labels Jul 4, 2024
@guicassolato guicassolato changed the title common policy status controller [state-of-the-world] common policy status controller Oct 2, 2024
@guicassolato
Copy link
Contributor

Let's add a task for this as part of the state-of-the-world main workflow.

Maybe we try to update the status of the Kuadrant CR to report it back to the user.

@guicassolato
Copy link
Contributor

Is this still valid? I believe it may have been fixed with #811 perhaps?

cc @KevFan

@eguzki
Copy link
Contributor Author

eguzki commented Oct 18, 2024

If the cert manager CRDs are not in place, TLS policies status report on that issue?

@KevFan
Copy link
Contributor

KevFan commented Oct 18, 2024

TLSPolicy was done as part of #885 for if CertManager CRDs are not detected.

This has not been done for any other Policies though

@KevFan KevFan self-assigned this Nov 8, 2024
@KevFan KevFan moved this from In Progress to Ready For Review in Kuadrant Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes user facing APIs kind/enhancement New feature or request participation/help wanted Extra attention is needed size/medium
Projects
Status: Ready For Review
Development

Successfully merging a pull request may close this issue.

3 participants