Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limit Policy status "HTTPRoute is ratelimited" is misleading #406

Closed
jsmolar opened this issue Jan 29, 2024 · 2 comments
Closed

Rate Limit Policy status "HTTPRoute is ratelimited" is misleading #406

jsmolar opened this issue Jan 29, 2024 · 2 comments
Milestone
v0.7.0

Comments

@jsmolar
Copy link
Contributor

jsmolar commented Jan 29, 2024

When RLP is applied, but not protecting any HTTPRoute, the status is HTTPRoute is ratelimited. This is not true in some cases. E.g. when there is no matching HTTPRoute rule for the limit.

Proposed change:
HTTPRoute is ratelimited to Policy is enabled
@KevFan
Copy link
Contributor

KevFan commented Feb 6, 2024

This is addressed by #347

@KevFan KevFan moved this to Done in Kuadrant Feb 15, 2024
@KevFan KevFan added this to the v0.7.0 milestone Feb 15, 2024
@KevFan
Copy link
Contributor

KevFan commented Feb 15, 2024

Closing as addressed by #347, which will be included in the next Kuadrant Operator release

@KevFan KevFan closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@jsmolar @KevFan