Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: upgrade controller runtime #237

Closed
KevFan opened this issue Aug 24, 2023 · 5 comments · Fixed by #246
Closed

dep: upgrade controller runtime #237

KevFan opened this issue Aug 24, 2023 · 5 comments · Fixed by #246
Assignees
@KevFan
Labels
area/dependencies Changes dependencies kind/enhancement New feature or request size/medium
Milestone
v0.5.0

Comments

@KevFan
Copy link
Contributor

KevFan commented Aug 24, 2023 •
edited
Loading

As a pre-req to #203, we should upgrade the controller runtime version

The next minor versions of controller runtime introduces several breaking changes that would need to be addressed from this upgrade.

This should be completed after the upgrade to Go 1.20 #236 is complete
@KevFan KevFan added kind/enhancement New feature or request status/blocked Blocked by something... size/medium area/dependencies Changes dependencies labels Aug 24, 2023
@guicassolato
Copy link
Contributor

guicassolato commented Aug 24, 2023 •
edited
Loading

Let's check with https://github.com/kubernetes-sigs/gateway-api about their plans on moving from v0.15.1 to latest (v0.16.0, as of today), even though, to be fair, the difference between these releases has been no much longer than just a couple weeks apart.

@KevFan
Copy link
Contributor Author

KevFan commented Aug 29, 2023

Gateway-api has moved to v0.16.0 of controller runtime as part of their latest (v0.8.0) release - https://github.com/kubernetes-sigs/gateway-api/tree/v0.8.0

@KevFan KevFan mentioned this issue Aug 31, 2023
Merged
@alexsnaps alexsnaps added this to the v0.5.0 milestone Sep 12, 2023
@KevFan
Copy link
Contributor Author

KevFan commented Sep 19, 2023 •
edited
Loading

Controller runtime v0.16.1 is used as part of the gatway-api v0.8.1 release

@KevFan
Copy link
Contributor Author

KevFan commented Oct 26, 2023

Controller runtime v0.16.2 is used as part of the gateway-api v1.0.0-rc2 release

@KevFan
Copy link
Contributor Author

KevFan commented Nov 1, 2023

Gateway api v1.0.0 has been released using controller runtime v0.16.3

@KevFan KevFan added target/current and removed status/blocked Blocked by something... labels Nov 1, 2023
@KevFan KevFan self-assigned this Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Review to To test in Kuadrant Service Protection Nov 7, 2023
@KevFan KevFan mentioned this issue Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevFan KevFan

Labels
area/dependencies Changes dependencies kind/enhancement New feature or request size/medium
Projects
No open projects
Kuadrant Service Protection
Status: To test
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

refactor: controller-runtime v0.16.3 KevFan/kuadrant-operator
3 participants
@alexsnaps @guicassolato @KevFan