Incorrect status.condition Message When `spec.limil is Missing in RLP

[jsmolar]

When a RateLimitPolicy (RLP) is created without specifying spec.limi, the status.condition shows the following message:

- lastTransitionTime: '2024-11-14T12:54:54Z'
  message: RateLimitPolicy is not in the path to any existing routes
  reason: Unknown
  status: 'False'
  type: Enforced

The status.condition should display a more relevant message indicating the missing spec.limi field, instead of suggesting that the policy is not tied to any route.

[Boomatang]

What do you believe would be the correct error message in this case? I also going to ask should a user be allowed to create a RateLimitPolicy without specifying the spec.limit?

[jsmolar]

@Boomatang I think you should spec.limit should be required (spec.targetRef is). If not, RLP should not show error message.