-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError when click Accept directly on custom color select #44
Comments
Fixed on 3.0.1 Thanks for the report |
Hi Krone,
The issue isn´t resolved.
I’ve getting the same error.
|
is working on https:\ngx-colors.web.app let me test it. |
please confirm you are using v3.0.1, bc i cant replicate the error after installing the library on a blank angular proyect |
Hi,
Yes, i’m using the last version (3.0.1). I’m getting the same error: Cannot read properties of null (reading 'h')
The erros is in “hsvaToRgba(hsva)” function
The concrete line is: const h = hsva.h, s = hsva.s, v = hsva.v, a = hsva.a;
Perhaps the error is raised when the control hasn't a default color. In our case the default color is empty. In your examples all controls has a deafult color defined.
|
Hi, @ServerSports let me test it, thanks for the report. im going to try to fix it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
The version 3.0.0. has a error. When you click ACCEPT button label directly (in custom color selector), before change any value on slidebar or picker, you get the next error: TypeError: Cannot read properties of undefined (reading 'h')
You can check it in your demo app.
Regards.
The text was updated successfully, but these errors were encountered: