Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual option for a Solarized-Dark-Fix #68

Closed
fbruetting opened this issue Nov 13, 2023 · 2 comments
Closed

Manual option for a Solarized-Dark-Fix #68

fbruetting opened this issue Nov 13, 2023 · 2 comments

Comments

@fbruetting
Copy link

fbruetting commented Nov 13, 2023

The Solarized Dark color scheme is very popular because of it’s eye-friendlyness – but sadly it violates the terminal color specification, because some bright color variants contain very dark tones and the grey tones being too near to the background color tone. This is due to Solarized’s color logic which doesn’t align well with the terminal color palette definition.

Here’s it’s color palette (in German, but I’m sure you get it):
Bildschirmfoto vom 2023-11-13 17-38-42

This leads to text parts in Julia not being readable, especially visible in stack traces, see the difference here:

Bildschirmfoto vom 2023-11-13 17-43-50 Bildschirmfoto vom 2023-11-13 17-43-44

There’s a big Julia thread here JuliaLang/julia#38730, and we already discussed to quite some extent in the DataFrames issue JuliaData/DataFrames.jl#3400.

The best solution seems to let Solarized be broken, because e.g. hard-coding that color would negatively impact all other themes. But because of Solarized’s enormous popularity, it would be nice if we could have a handy manual solution – e.g. being able to define an ENV or execute a config function to alter that color tone. And as it affects whole Julia, it seems to be best implemented in Crayons.

So: Is it possible to implement something like an ENV SOLARIZED_DARK_FIX[=<COLOR>] which alters that color to a predefined color (terminal colors 242-246 are quite usable, see JuliaData/DataFrames.jl#3400)? Best if a custom color could optionally be specified.

@tecosaur
Copy link

tecosaur commented Aug 15, 2024

This should be fixed by JuliaLang/julia#51816, if/when it gets merged.

@KristofferC
Copy link
Owner

I don't think this issue has anything to do with this package really. It isn't used in Base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants