From 38e7ef2f48f217c0706123b1134a36378bde2f22 Mon Sep 17 00:00:00 2001 From: KrishVora01 Date: Mon, 10 Jun 2024 12:25:17 +0530 Subject: [PATCH] modifying comments in doi dockerfile --- docker/prepare_docker_official_image_source.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docker/prepare_docker_official_image_source.py b/docker/prepare_docker_official_image_source.py index a39915c9e51f2..a4c6aa2191ae6 100644 --- a/docker/prepare_docker_official_image_source.py +++ b/docker/prepare_docker_official_image_source.py @@ -36,14 +36,18 @@ from distutils.dir_util import copy_tree import os import shutil +import re -def remove_args_and_hardcode_values(file_path, kafka_url): +def remove_args_and_hardcode_values(file_path, kafka_version, kafka_url): with open(file_path, 'r') as file: filedata = file.read() filedata = filedata.replace("ARG kafka_url", f"ENV kafka_url {kafka_url}") filedata = filedata.replace( "ARG build_date", f"ENV build_date {str(date.today())}") + original_comment = re.compile(r"# Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments") + updated_comment = f"# Get Kafka from https://downloads.apache.org/kafka for version {kafka_version} passed in the env var" + filedata = original_comment.sub(updated_comment, filedata) with open(file_path, 'w') as file: file.write(filedata) @@ -65,4 +69,4 @@ def remove_args_and_hardcode_values(file_path, kafka_url): copy_tree(os.path.join(current_dir, args.image_type), os.path.join(new_dir, args.kafka_version, args.image_type)) copy_tree(os.path.join(current_dir, 'resources'), os.path.join(new_dir, args.kafka_version, args.image_type, 'resources')) remove_args_and_hardcode_values( - os.path.join(new_dir, args.kafka_version, args.image_type, 'Dockerfile'), kafka_url) + os.path.join(new_dir, args.kafka_version, args.image_type, 'Dockerfile'), args.kafka_version, kafka_url)