Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When embedding SVGs duplicate IDs trip up the html validator #563

Open
rhpvorderman opened this issue Apr 15, 2024 · 1 comment
Open

When embedding SVGs duplicate IDs trip up the html validator #563

rhpvorderman opened this issue Apr 15, 2024 · 1 comment

Comments

@rhpvorderman
Copy link

First of all, thanks for making PyGAL. I love it. It is by far the best plotting library for python. Rendering plain SVG is supercool. It allows embedding directly in the HTML. That in turn allows loading the javascript only once by also embedding it in the HTML and turning the JS property for all the figures off.

Embedding does come with the disadvantage of tripping up the HTML5 validator, as IDs will be duplicated.

I can write a PR to fix this, giving each sery an unique ID. Are there objections to this?

"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":233.658917-233.658980: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":256.78106-256.78169: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":256.78283-256.78346: error: Duplicate ID "activate-serie-1".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":256.78461-256.78524: error: Duplicate ID "activate-serie-2".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":256.78637-256.78700: error: Duplicate ID "activate-serie-3".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":256.78818-256.78881: error: Duplicate ID "activate-serie-4".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":345.24677-345.24740: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":363.227548-363.227611: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":363.227720-363.227783: error: Duplicate ID "activate-serie-1".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":363.227893-363.227956: error: Duplicate ID "activate-serie-2".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":363.228066-363.228129: error: Duplicate ID "activate-serie-3".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":381.68155-381.68218: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":408.49143-408.49206: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":420.299314-420.299377: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":452.164928-452.164991: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":452.165125-452.165188: error: Duplicate ID "activate-serie-1".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":452.165302-452.165365: error: Duplicate ID "activate-serie-2".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":480.22390-480.22453: error: Duplicate ID "activate-serie-0".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":480.22580-480.22643: error: Duplicate ID "activate-serie-1".
"file:/home/rhpvorderman/PycharmProjects/sequali/5millionreads_R1.fastq.html":543.17559-543.17622: error: Duplicate ID "activate-serie-0".
@gentooboontoo
Copy link
Member

First of all, thanks for making PyGAL. I love it. It is by far the best plotting library for python.

Thank you on behalf of all the contributors thus far.

I can write a PR to fix this, giving each sery an unique ID. Are there objections to this?

It would be great to have a PR fixing the problem in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants