-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for webcal-subscriptions #1229
Added support for webcal-subscriptions #1229
Conversation
e914b9d
to
5b386d3
Compare
@Unrud Please approve this pull request. |
Since Radicale does not announce calendars which do not belong to the user but are accessible to read, this would be a very convenient workaround in my workflow! |
I would like to share my existing Radicale calendars with a public (passwordless) read-only URL so that it works with google calendar and such. edit: I think that was mostly irrelevant, and I got passwordless subscriptions working already by setting the following: in
in
then create a public folder/user and symlink the relevant calendars to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like at least not breaking anything
Tested with Apache, works fine. Repo org community site is 500, nothing else done to this repo since earlier mid-year. |
https://radicale.org/ is working, @Unrud : can you approve the pull request? |
I meant their GitHub community site, https://community.kozea.fr/. |
fcfd74f
to
bd57f53
Compare
Update: Upstreamed to master to include latest changes, no merge conflicts. ℹ️ As a side note: the Github Actions configuration seems to be broken though, it's using some outdated python version strings (see pipeline log and the list of supported python versions of the Github Actions module). |
Why hasn't this PR been merged yet? Is there anything I can do to help it along? |
Same question here :) |
3c10d42
to
7b6ac19
Compare
Update: Upstreamed to master to include latest changes:
Regarding my previous side note: I see the Github Actions configuration has been fixed, nice! :) Using that as a quick reminder that this PR is ready to be merged! |
@Unrud Do you require any additional adjustments to this PR from my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, only extensions
If it's approved, Why it's not merged yet?! |
@mmBesar There hasn't been much activity on this project lately. The last commit is from mid-April, so I believe the maintainer simply didn't have the time to look into it since this PR was approved. In case you want to try out an alternative, you may want to check out https://sabre.io/baikal/. |
@leso-kn I have Baikal installed. |
@mmBesar According to https://sabre.io/dav/clients/ical/#subscriptions it should be possible, though it seems like you need to manually create the object (just like with this implementation for Radicale) or use a client that supports adding server-side webcal subscriptions (e.g. iCal). |
@leso-kn Not available yet! |
Had a look at the web UI and it wouldn't be difficult to add Webcal support to the UI that builds off @leso-kn's great work. +1 for merging this PR. |
@Kozea can we merge please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@leso-kn : can you please create an empty commit to trigger "actions"? See here for more information: https://stackoverflow.com/questions/52408592/how-to-relaunch-github-check-without-pushing-new-commits |
Add check for base_prefix indicating Radicale running at site root (/)
Revert "Add check for base_prefix indicating Radicale running at site root (/)"
316f57e
to
7b6ac19
Compare
7b6ac19
to
94a5ff0
Compare
@pbiering done. Also rebased against master, which makes the docs job fail but that's only due to the branch name. All tests pass on all platforms. |
@leso-kn : I have requested enabling GitHub's Wiki for radicale, once enabled it would be great to have example documented there. |
Added support to view, edit, and add Webcals in web UI to support functionality added in PR Kozea#1229.
@MatthewHana oh, Nice work! That's very cool |
This PR adds support for webcal subscriptions, as discussed in #776.
Please note, that this is a backend-focused implementation, so efforts to adapt the web UI have not been made in this changeset.
Webcal subscriptions can be added in the form of a collection, just like calendars, todo lists and the like. The URL to the targeted online ICS file, as well as the display name and an optional color for the calendar are stored in the
.Radicale.props
file of the regarding collection.Steps to subscribe to a calendar manually:
collection-root/
directory.Radicale.props
file, structured as shown in the example belowThe subscribed calendar will now be advertised by Radicale and should appear in supported applications (e.g. DAVx⁵ for Android)
Example:
Result (DAVx⁵ + ICSx⁵):