Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions trigger errors during code validation #1366

Closed
pbiering opened this issue Mar 1, 2024 · 1 comment
Closed

Actions trigger errors during code validation #1366

pbiering opened this issue Mar 1, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@pbiering
Copy link
Collaborator

pbiering commented Mar 1, 2024

Can one support here please:

https://github.com/Kozea/Radicale/actions/runs/8116969424/job/22188139714?pr=1365

radicale/storage/multifilesystem/base.py:47: error: Argument 1 to "contextmanager" has incompatible type "Callable[[CollectionBase, str, str, str | None], Iterator[IO[AnyStr]]]"; expected "Callable[..., Iterator[IO[Never]]]"  [arg-type]
radicale/storage/multifilesystem/meta.py:64: error: Need type annotation for "fo"  [var-annotated]
radicale/storage/multifilesystem/cache.py:89: error: Need type annotation for "fo"  [var-annotated]
radicale/storage/multifilesystem/sync.py:98: error: Need type annotation for "fo"  [var-annotated]
radicale/storage/multifilesystem/upload.py:46: error: Need type annotation for "fo"  [var-annotated]

best would be a PR against https://github.com/pbiering/Radicale/tree/fix-actions as I'm collecting here all which is required to make "Actions" happy again.

@pbiering pbiering added the bug label Mar 1, 2024
@pbiering pbiering self-assigned this Mar 1, 2024
@pbiering pbiering added this to the 3.1.9 milestone Mar 1, 2024
@pbiering pbiering assigned pbiering and unassigned pbiering Mar 2, 2024
@pbiering
Copy link
Collaborator Author

pbiering commented Mar 2, 2024

fixed now by appling "# type: ignore" with #1365 and leave "TODO".

Support for final fix would be nice.

@pbiering pbiering closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant