Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline assertFailsWith marks as uncovered #251

Closed
soywiz opened this issue Oct 4, 2022 · 6 comments
Closed

Multiline assertFailsWith marks as uncovered #251

soywiz opened this issue Oct 4, 2022 · 6 comments
Assignees
@shanshin
Labels
Bug Bug issue type Kover Coverage Tool S: postponed Status: work on the issue is not in the short term plans

Comments

@soywiz
Copy link
Contributor

soywiz commented Oct 4, 2022 •
edited
Loading

In 0.6.1 with ./gradlew koverMergedXmlReport uploaded to codecov:

https://app.codecov.io/github/korlibs/korge/blob/31ceb8d90c8adf02931e410d385f704e513d56b4/kds/src/commonTest/kotlin/com/soywiz/kds/QueueTest.kt

Screenshot 2022-10-04 at 18 24 25

Also I'm getting some strange partial here in the same file:

Screenshot 2022-10-04 at 18 24 58
@shanshin
Copy link
Collaborator

shanshin commented Oct 4, 2022 •
edited
Loading

Hi,
at the moment, correct integration with codecov is not guaranteed.

Could you please show the Kover HTML report? How different is it from codecov.

@soywiz
Copy link
Contributor Author

soywiz commented Oct 4, 2022 •
edited
Loading

@shanshin

Screenshot 2022-10-04 at 19 39 28

You should be able to reproduce this report with:

git clone https://github.com/korlibs/korge.git
git checkout 3b7f877eb1fb3be09e9669453a86eb75c1b3df23
./gradlew :kds:koverHtmlReport

@shanshin shanshin self-assigned this Oct 27, 2022
@shanshin shanshin added Bug Bug issue type Kover Coverage Tool S: confirmed Status: bug is reproduced or present labels Oct 27, 2022
@zuevmaxim
Copy link

List.isNotEmpty partial coverage is fixed in agent version 1.0.688

As for assertFailesWith, this issue is caused by insufficient support of @InlineOnly functions in the coverage agent

@soywiz soywiz mentioned this issue Nov 22, 2022
Merged
@soywiz
Copy link
Contributor Author

soywiz commented Nov 22, 2022

Nice! Confirmed that List.isNotEmpty thing is fixed:

Screenshot 2022-11-22 at 12 00 48

@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: confirmed Status: bug is reproduced or present labels Nov 22, 2022
@zuevmaxim
Copy link

Related issue about InlineOnly functions https://youtrack.jetbrains.com/issue/KT-55381

@shanshin shanshin added S: postponed Status: work on the issue is not in the short term plans and removed S: in progress Status: implementing or design in process labels Dec 13, 2022
@shanshin
Copy link
Collaborator

Fixed since 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type Kover Coverage Tool S: postponed Status: work on the issue is not in the short term plans
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soywiz @shanshin @zuevmaxim