-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework ModelPatcher for upcoming ComfyUI update #498
Open
Kosinkadink
wants to merge
48
commits into
main
Choose a base branch
from
rework-modelpatcher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_module code to manually parse load_state_dict load_result
…gic to allow applying zsnr for non-lcm
…s differently and most adjustments are no longer necessary (and their presence makes the nodes too wide)
…mfyUI to get rid of a bunch of hacky code (and to enable hookable patches)
…ode to match ComfyUI changes
… ModelPatcher wrappers/patches, removed no-longer used code, removed model_name from InjectionParams
…on) code after code refactor
…ector as upcoming ComfyUI/ACN changes will make its use obsolete
…stead of a global variable
…yUI memory management system
…tures (will deprecate almost all these nodes soon after testing)
… be safely merged into main, will need to get working properly later
…vancing too quick
…perly with new memory management
… respect ComfyUI expected behavior
…apper instead to fix weird issue with ContextRef + ImageInjection
…at uses built-in ComfyUI wrapper for apply_model
3 tasks
….hook function params
…ustom ModelPatcher model is required; no more mismatches between ComfyUI and ADE ModelPatcher features. Also made Scale Ref Image and VAE Encode node use batched vae encoding
…t layers, as well as mm_kwargs were applicable, so that behavior can be more easily extended in the future, both from ADE code and other node packs
…sed to determine if down/up blocks should be present and the attention block count, added init_kwargs input to AnimateDiffModel so some behavior can be adapted by unusual models
… refactored MotionModelPatchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies code to use ComfyUI's built-in hooks/wrappers/callbacks system from the PR I submitted, allowing a bunch of hacks to be removed.
Notable changes/features: