Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ModelPatcher for upcoming ComfyUI update #498

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

Kosinkadink
Copy link
Owner

@Kosinkadink Kosinkadink commented Nov 12, 2024

Modifies code to use ComfyUI's built-in hooks/wrappers/callbacks system from the PR I submitted, allowing a bunch of hacks to be removed.

Notable changes/features:

  • SamplerCustomAdvanced support due to use of new ComfyUI wrappers
  • More robust loading logic
  • Ported lora hook nodes to use the built-in ComfyUI hooking system internally, and deprecated them in favor of the more convenient built-in nodes

…_module code to manually parse load_state_dict load_result
…s differently and most adjustments are no longer necessary (and their presence makes the nodes too wide)
…mfyUI to get rid of a bunch of hacky code (and to enable hookable patches)
… ModelPatcher wrappers/patches, removed no-longer used code, removed model_name from InjectionParams
…ector as upcoming ComfyUI/ACN changes will make its use obsolete
…tures (will deprecate almost all these nodes soon after testing)
… be safely merged into main, will need to get working properly later
@Kosinkadink Kosinkadink marked this pull request as ready for review November 18, 2024 14:59
…ustom ModelPatcher model is required; no more mismatches between ComfyUI and ADE ModelPatcher features. Also made Scale Ref Image and VAE Encode node use batched vae encoding
…t layers, as well as mm_kwargs were applicable, so that behavior can be more easily extended in the future, both from ADE code and other node packs
…sed to determine if down/up blocks should be present and the attention block count, added init_kwargs input to AnimateDiffModel so some behavior can be adapted by unusual models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant