Skip to content

Index hold "0.0:" not working as expected #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixniemeyer opened this issue Oct 20, 2024 · 2 comments
Open

Index hold "0.0:" not working as expected #487

felixniemeyer opened this issue Oct 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@felixniemeyer
Copy link

I'm expecting "0.0:" to hold that prompt until the idx of the next prompt.

However, I observe, that it holds for only one frame and then switches over to the next already.

Have a look at the prompts and the comfy output it produces:
image

image

The first prompt appears only on one line. I had expected it to go from 0.0 to 0.33.
Further, I had expected the second prompt to go from 0.33 to 0.5, third from 0.5 to 0.66, and fourth from 0.66 till the end.


These expectation are based on the text from the help box:

hold: Putting a colon after a single idx stops interpolation until the next provided index. Examples -> 0:, 0.5:, 16:
@felixniemeyer
Copy link
Author

I looked into the code and found this function doing a lot of things related to "hold" and "holders":

def handle_prompt_interpolation(pairs: list[InputPair], length: int, clip: CLIP, options: PromptOptions):

The function is so large, I'm scared to investigate.


In the meantime, I'm using ranges instead of "hold" as a workaround:
image
image
you can see, that the first prompt is now used for more than 1 frame.

@Kosinkadink
Copy link
Owner

Thanks for the detailed report, I'll look into this soon

@Kosinkadink Kosinkadink added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants