Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README for group & account commands #24

Open
amit-pub opened this issue Jul 24, 2021 · 2 comments
Open

Fix README for group & account commands #24

amit-pub opened this issue Jul 24, 2021 · 2 comments

Comments

@amit-pub
Copy link
Contributor

amit-pub commented Jul 24, 2021

  1. While adding a group, --group is required

Readme says:

sherlock add group detective

Existing behavior:

# sherlock add group g7
❗ account name required (--name)
  1. While adding an account to a group, --name is required

Readme says:

sherlock add account bakerstreet --gid detective --tag 221b

Existing behavior:

# sherlock add account  g1-a2 --gid g8 --insecure
❗ account name required (--name)
@KonstantinGasser
Copy link
Owner

@amit-pub thanks for pointing this out. Forgot to align the README when I did my last changes - thanks! 👍

@amit-pub
Copy link
Contributor Author

amit-pub commented Jul 26, 2021

@KonstantinGasser I've created the PR for the same already - #25
you can approve if its LGTY & Merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants