Revert "chore(release): v0.9.1 release - Trezor login hot-fix"#2781
Merged
Revert "chore(release): v0.9.1 release - Trezor login hot-fix"#2781
v0.9.1 release - Trezor login hot-fix"#2781Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update removes all code and state related to portfolio-wide price changes and 24h change calculations, eliminates secure password storage from Trezor login flows, and replaces external password utilities with custom logic. It also simplifies wallet UI by reducing tabs, unifying portfolio charts, and removing mobile-specific or redundant UI components. Some dependencies and versioning are reverted. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WalletUI
participant TrezorInitBloc
participant SDK
User->>WalletUI: Initiate Trezor login
WalletUI->>TrezorInitBloc: Login event
TrezorInitBloc->>SDK: signIn/register (password: 'hidden-login', derivation: iguana)
SDK-->>TrezorInitBloc: Success/Failure
TrezorInitBloc-->>WalletUI: Login result
sequenceDiagram
participant WalletUI
participant PortfolioGrowthBloc
participant PortfolioGrowthRepository
WalletUI->>PortfolioGrowthBloc: Load portfolio growth event
PortfolioGrowthBloc->>PortfolioGrowthRepository: Fetch growth chart
PortfolioGrowthRepository-->>PortfolioGrowthBloc: Chart data
PortfolioGrowthBloc-->>WalletUI: Chart data only (no aggregate balance/24h change)
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 9a8e4a1): https://walletrc--pull-2781-merge-byhd70rq.web.app (expires Sun, 22 Jun 2025 16:01:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2743
Summary by CodeRabbit