Skip to content

ci: upgrade workflows to flutter 3.29#2531

Merged
CharlVS merged 4 commits intodevfrom
ci/upgrade-to-flutter-3.29
Feb 17, 2025
Merged

ci: upgrade workflows to flutter 3.29#2531
CharlVS merged 4 commits intodevfrom
ci/upgrade-to-flutter-3.29

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented Feb 17, 2025

Summary by CodeRabbit

  • Chores

    • Upgraded the Flutter version across development, build, and dependency pipelines.
    • Updated the native toolchain to a newer version.
    • Removed outdated asset references.
  • Documentation

    • Revised documentation to reflect the updated Flutter release and related commands.

@takenagain takenagain added bug Something isn't working CI labels Feb 17, 2025
@takenagain takenagain self-assigned this Feb 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 17, 2025

Walkthrough

This pull request updates several development configuration files by upgrading Flutter from earlier versions to 3.29.0 (or 3.29.x in the Actions workflow) and updating the NDK version. Two Dockerfiles and documentation now reference the new Flutter version, while the GitHub Actions workflow reflects a similar change. In addition, the Android build file modifies the NDK version, and two asset paths are removed from the Flutter assets configuration. No changes to control flow or core application logic are included.

Changes

File(s) Change Summary
.devcontainer/…/komodo-wallet-android-dev.dockerfile, .docker/…/komodo-wallet-android.dockerfile Updated FLUTTER_VERSION from "3.22.3" to "3.29.0".
.github/…/action.yml, docs/FLUTTER_VERSION.md Updated Flutter version: workflow changed from "3.27.x" to "3.29.x" and documentation from "3.22.3" to "3.29.0".
android/app/build.gradle Updated ndkVersion from "26.3.11579264" to "27.2.12479018".
pubspec.yaml Removed two asset paths from the Flutter assets configuration.

Possibly related PRs

Suggested labels

enhancement

Poem

I'm a little rabbit with code in my paws,
Hopping through Dockerfiles without a pause.
Flutter's fresh update makes my ears perk high,
As NDK bounds onward, reaching for the sky!
With assets trimmed and changes so spry,
I celebrate with a joyful hop—oh my!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@takenagain
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 17, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/FLUTTER_VERSION.md (1)

11-15: Enhance Fenced Code Block Syntax Highlighting
Consider adding a language identifier (for example, ```bash) to the fenced code block to improve readability and provide syntax highlighting. This would address the markdownlint hint regarding fenced code blocks.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

11-11: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9abd03 and f7363e6.

📒 Files selected for processing (6)
  • .devcontainer/komodo-wallet-android-dev.dockerfile (1 hunks)
  • .docker/komodo-wallet-android.dockerfile (1 hunks)
  • .github/actions/flutter-deps/action.yml (1 hunks)
  • android/app/build.gradle (1 hunks)
  • docs/FLUTTER_VERSION.md (1 hunks)
  • pubspec.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • pubspec.yaml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/FLUTTER_VERSION.md

11-11: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build_and_preview
  • GitHub Check: validate_code_guidelines
🔇 Additional comments (5)
.github/actions/flutter-deps/action.yml (1)

9-10: Update Flutter Version in Action Configuration
The Flutter version has been updated to "3.29.x", which aligns with the overall PR objectives. Ensure that the use of the "x" notation is intentional for picking up patch releases.

android/app/build.gradle (1)

58-58: NDK Version Upgrade
The ndkVersion has been updated to '27.2.12479018'. Please verify that this version is compatible with your native modules and that it passes all integration tests.

.docker/komodo-wallet-android.dockerfile (1)

15-15: Dockerfile Flutter Version Update
The FLUTTER_VERSION environment variable is now set to "3.29.0", which is consistent with the PR’s upgrade target.

.devcontainer/komodo-wallet-android-dev.dockerfile (1)

5-5: Dev Container Flutter Version Update
The update to ENV FLUTTER_VERSION="3.29.0" ensures that the development container is aligned with the new Flutter version across all environments.

docs/FLUTTER_VERSION.md (1)

7-8: Documentation Version Update
The documented Flutter version has been updated to 3.29.0. This change is consistent with the updates across the CI and Docker configurations.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit f7363e6):

https://walletrc--pull-2531-merge-vkjvk7ek.web.app

(expires Mon, 24 Feb 2025 07:37:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain requested a review from CharlVS February 17, 2025 07:38
@takenagain takenagain marked this pull request as ready for review February 17, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants