Conversation
add boolean flag to classes rather than creating a new asset manager type that makes the assets interface more cumbersome to use
Significant changes include: - Updated the commit reference for bundled coins in the build configuration - Added a new class, CustomAssetHistoryStorage, to manage custom token history - Enhanced AssetManager to handle custom tokens by adding them to wallet history and activating them - Extended the Asset class with a method to create an instance from JSON data
fixes runtime error in KW where wallet page fails to load due to ticker index not being initialized
takenagain
force-pushed
the
feature/custom-token-import
branch
from
9489a18 to
75b7d5c
Compare
the custom token erc20 activation strategy was placed in the factory which had it's reference removed in the latest changes or merge from dev
CharlVS
requested changes
Feb 10, 2025
Collaborator
CharlVS
left a comment
CharlVS
left a comment
There was a problem hiding this comment.
Awesome work! I'm happy with the architectural changes. Everything meets the standard I'm striving for and is consistent with the current architecture.
Thank you for taking the time to fully understand the architecture and the broader context of your changes. The system has many components and is mostly undocumented. When we have some breathing room and a stable release, we'll work together to document everything (mainly me) and on test coverage (mainly you)
| } | ||
|
|
||
| /// [AddressFormat] format field options. | ||
| enum AddressFormatFormat { |
Collaborator
There was a problem hiding this comment.
This enum is confusing/redundant. Can you rename it to something clearer? I suggest AddressFormatType.
CharlVS
approved these changes
Feb 10, 2025
Collaborator
CharlVS
left a comment
CharlVS
left a comment
There was a problem hiding this comment.
Spicy. Some of your best contributions to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes