feat(coin-updates): integrate komodo_coin_updates into komodo_coins#190
Merged
feat(coin-updates): integrate komodo_coin_updates into komodo_coins#190
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
komodo_coin_updatesto useAssetfor storage and retrieval, removing most of the legacy models and adapters in the process.komodo_coin_updatestohive_ce.build_config.jsontokomodo_coin_updatesto read the coin configuration settings.komodo_coin_updatesandkomodo_coinsto validate the desired functionality works as expected.komodo_coin_updatespackage.komodo_coin_updatesintokomodo_coins, replacing the hard-coded URL bypassing any local coin config files.Screen.Recording.2025-08-22.at.17.02.07.mov
Local testing
Update
packages/komodo_defi_framework/assets/configwith the contents of coins_config.json from23b16a0.Modify the following values in
packages/komodo_defi_framework/app_build/build_config.jsonwith the following values. This will prevent thecoins_config.jsonfrom being overridden with an updated version at build time.Register a new account.
Search for "NYC" and "DIMI". Confirm that "NYC" does not have a UTXO/Smart coin and "DIMI" cannot be activated due to missing derivation path.
Refresh page and sign back in.
Search for "NYC" and "DIMI" again and confirm that NYC now has a UTXO coin and "DIMI" can now be activated.
Summary by CodeRabbit