fix(offline-keys): use CryptoCtx for Iguana get_private_keys#2683
Merged
fix(offline-keys): use CryptoCtx for Iguana get_private_keys#2683
Conversation
shamardy
added
priority: urgent
smk762
approved these changes
Nov 10, 2025
There was a problem hiding this comment.
Tested this in Komodo Wallet dev branch, using flutter sdk from https://github.com/KomodoPlatform/komodo-defi-sdk-flutter/tree/fix_priv_key_export and was returned expected keys, matching address/pk output in legacy desktop.
Pubkey for same mnemonic via postman resolves to expected address.
Note: Existing known iguana segwit pk handling bug still present.
DeckerSU
added a commit
to GLEECBTC/komodo-defi-sdk-flutter
that referenced
this pull request
Nov 10, 2025
This was referenced Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug where
get_private_keysin iguana mode derived keys from an empty passphrase whenctx.conf["passphrase"]is null (when loading it from KDF encrypted storage) instead of the active wallet secret, returning incorrect keys.Fixes #2682