fix(legacy-swap): make payment transaction broadcast interval smaller#2680
Merged
fix(legacy-swap): make payment transaction broadcast interval smaller#2680
Conversation
added 2 commits
October 31, 2025 12:08
…r iOS app not to lose message due to switching into BG)
shamardy
reviewed
Nov 5, 2025
shamardy
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces delays for legacy atomic swaps on the iOS platform.
When the Komodo Wallet iOS app transitions to the background, existing network connections may be disrupted. When the user returns the app to the foreground, running swaps should automatically resume and continue exchanging P2P messages.
However, we observed cases where swaps remained stuck in the MakerPaymentReceived or TakerPaymentSpent states for extended periods (sometimes over an hour).
Root Cause
The issue was caused by an excessively long P2P message re-broadcast interval (600 seconds). Since the default iOS auto-lock timeout is 30 seconds, the app often returned to the background before another broadcast could occur. As a result, p2p messages with payment transactions were not re-sent or received in time.
Fix
This PR reduces the P2P re-broadcast interval from 600 seconds to 15 seconds, ensuring that at least one re-broadcast happens while the app remains active in the foreground.