improvement(sse-example): copy the query params in the url to the event-stream initialization#2678
Merged
onur-ozkan merged 1 commit intodevfrom Nov 1, 2025
Merged
Conversation
in the example html sse init file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this was confusing for some (the fact that the query param to specify the client id goes inside the
EventSourceconstructor rather than a query parameters of the open html file on browser's url bar; i.e. u need to edit the html file to change the client id).This PR just copies the the query params from the url bar into the
EventSourceconstructor, which means we no longer have to edit the html file manually but rather just include any query params we want in the url search bar directly.