Skip to content

improvement(RPC): make params payload flexible for certain RPCs#2612

Merged
onur-ozkan merged 2 commits intodevfrom
get_enabled_coins-fix
Sep 4, 2025
Merged

improvement(RPC): make params payload flexible for certain RPCs#2612
onur-ozkan merged 2 commits intodevfrom
get_enabled_coins-fix

Conversation

@onur-ozkan
Copy link
Copy Markdown

@onur-ozkan onur-ozkan commented Sep 4, 2025

Makes get_enabled_coins, task::init_trezor::init and wc_get_sessions RPCs to accept empty params field without any breaking change on the API.

Closes #2498

Signed-off-by: Onur Özkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Copy Markdown
Author

cc @smk762

@smk762
Copy link
Copy Markdown

smk762 commented Sep 4, 2025

Thanks - I've confirmed this is working for v2 get_enabled_coins, but the other two methods (task::init_trezor::init, wc_get_sessions) in the linked issue still return the same error response, and in logs:

04 08:41:55, mm2_main::rpc:177] ERROR RPC dispatcher error: dispatcher:144] Error parsing request: invalid type: null, expected struct RpcInitReq
04 08:42:19, mm2_main::rpc:177] ERROR RPC dispatcher error: dispatcher:144] Error parsing request: invalid type: null, expected struct EmptyRpcRequest

Signed-off-by: Onur Özkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Copy Markdown
Author

7923bf9 should fix them.

@onur-ozkan onur-ozkan changed the title improvement(RPC): make get_enabled_coins payload flexible improvement(RPC): make params payload flexible for certain RPCs Sep 4, 2025
Copy link
Copy Markdown

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed params presence is permissive on all 3 methods listed in issue. Thanks!

@onur-ozkan onur-ozkan merged commit 8ecf882 into dev Sep 4, 2025
21 of 27 checks passed
@onur-ozkan onur-ozkan deleted the get_enabled_coins-fix branch September 4, 2025 12:45
dimxy pushed a commit that referenced this pull request Oct 15, 2025
)

* make `get_enabled_coins` payload flexible

Signed-off-by: Onur Özkan <work@onurozkan.dev>

* fix `task::init_trezor::init` and `wc_get_sessions`

Signed-off-by: Onur Özkan <work@onurozkan.dev>

---------

Signed-off-by: Onur Özkan <work@onurozkan.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants