feat(taproot): support parsing taproot output address types#2423
Merged
feat(taproot): support parsing taproot output address types#2423
Conversation
mariocynicys
added
status: pending review
priority: medium
shamardy
approved these changes
Apr 22, 2025
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Thanks for finding the problem and fixing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the issue and the error log in #2422 for context.
Basically, calls to
blockchain.transaction.getto electrum RPC fail when at least one of the outputs is a taproot output (even if not ours, as this is related to parsing the tx).This PR makes it so we don't fail parsing such output type. The taproot output type is parsed and just passed through without reading the scriptPubKey (just like nonstandard scripts). No internal address representation is created for it either, and it's not checked whether it's owned by us etc...
This PR minimally fixes #2422 (since we are not interested in storing nor spending taproot outputs).