feat(indexeddb): advanced cursor filtering impl#2066
Merged
Conversation
borngraced
changed the title
8 tasks
onur-ozkan
reviewed
Feb 22, 2024
Comment on lines
+274
to
+278
| /// Continues the cursor according to the provided `CursorAction`. If the action | ||
| /// is `CursorAction::Continue`, the cursor advances to the next item. If the action is | ||
| /// `CursorAction::ContinueWithValue`, the cursor advances to the specified value. If the | ||
| /// action is `CursorAction::Stop`, the cursor is stopped, and subsequent calls to `next` | ||
| /// will return `None`. |
There was a problem hiding this comment.
Could you reformat this explanation into multiple lines (per line for each action)?
onur-ozkan
reviewed
Feb 23, 2024
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
I will do the next review when this PR drops in-progress label and resolves the conflicts.
# Conflicts: # mm2src/mm2_db/src/indexed_db/drivers/cursor/cursor.rs
shamardy
reviewed
Mar 1, 2024
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Thank you for the PR! Only some minor comments and a question!
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Mar 13, 2024
* dev: feat(indexeddb): advanced cursor filtering impl (GLEECBTC#2066) update dockerhub destination repository (GLEECBTC#2082) feat(event streaming): configurable worker path, use SharedWorker (GLEECBTC#2080) fix(hd_tests): fix test_hd_utxo_tx_history unit test (GLEECBTC#2078) feat(network): improve efficiency of known peers handling (GLEECBTC#2074) feat(nft): enable eth with non fungible tokens (GLEECBTC#2049) feat(ETH transport & heartbeats): various enhancements/features (GLEECBTC#2058)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several new filtering features to the mm2 indexedbdb crate, including
limit,offset, with a minor fix forwhere_condition/option.closes: #2052, #2019