Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Use tini for the docker container. #743

Closed
saltydk opened this issue Mar 3, 2022 · 3 comments · Fixed by #762
Closed

Feature Request: Use tini for the docker container. #743

saltydk opened this issue Mar 3, 2022 · 3 comments · Fixed by #762
Assignees
Labels
enhancement New feature or request status:more-info-needed More information is needed

Comments

@saltydk
Copy link
Contributor

saltydk commented Mar 3, 2022

Is your feature request related to a problem? Please describe.
Docker container does not exit gracefully, use something like https://github.com/krallin/tini to properly shut things down. Instead of having to wait for docker to force kill the container.

Describe the solution you'd like
Use tini or something similar.

Describe alternatives you've considered
Not sure it applies.

Additional context
None.

@saltydk saltydk added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Mar 3, 2022
@meisnate12 meisnate12 added status:more-info-needed More information is needed and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Mar 6, 2022
@meisnate12
Copy link
Member

im gonna be honest im not sure how to use this

@saltydk
Copy link
Contributor Author

saltydk commented Mar 6, 2022

I can play around with it later and send a PR if you want.

@meisnate12
Copy link
Member

sure im always open to PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:more-info-needed More information is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants