Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: c.resize is not a function #21

Open
Chaotnix opened this issue Apr 18, 2021 · 12 comments
Open

TypeError: c.resize is not a function #21

Chaotnix opened this issue Apr 18, 2021 · 12 comments

Comments

@Chaotnix
Copy link

I tried running the shadertoy-exporter-1.4.0.exe on Windows 10, Java 1.8.
I get the error 'TypeError: c.resize is not a function' as soon as i click on export.

@FullstackJack
Copy link

There is no Java here, it's built with Electron which is JavaScript.

@tdhooper
Copy link
Collaborator

This is probably because shadertoy removed their internal resize function, I had the same issue with my frame exporter plugin, here's how I fixed it there if anyone needs a reference implementation:

tdhooper/shadertoy-frame-exporter@5f73b10

@Chaotnix
Copy link
Author

Thanks for the clarification.
Unfortunately I am not able to fix it by myself, because I can't even compile the code in VS Code.
There are always unresolved dependancies.
Maybe be I will try again, when I have some better understanding how npm, jspm an the other tools work.
Till then I will use tdhooper/shadertoy-frame-exporter. It does a great job.

@KoltesDigital
Copy link
Owner

Sorry for being late. I've fixed the resizing part. 9d471c3 @tdhooper I tried to use your change, but after all I copied the code executed on going fullscreen, this has the advantage of not visually resizing the canvas!

However, indeed the build process is now broken. I'll have a look at it.

@benoitmar
Copy link

Hello all,
I downloaded yesterday the shadertoy-exporter-1.4.0.exe.
I still get the c.resize error. Do you plan to make a new build with the fix ?

Thank you for making this tool, shadertoys rocks !

@Hitthesurf
Copy link

Hello all, I downloaded yesterday the shadertoy-exporter-1.4.0.exe. I still get the c.resize error. Do you plan to make a new build with the fix ?

Thank you for making this tool, shadertoys rocks !

I got this today, for windows 10, and I get the c.resize error.

@kilik128
Copy link

same here if somethink's have make new build it's can be good

@vladimirmujagic
Copy link

Any update regarding this issue? It's currently unusable

@sdedovic
Copy link

sdedovic commented Jan 7, 2022

I was able to build and use on MacOS 12 (Monterey) after blowing away the package-lock.json file and upgrading electron-builder to "^21.2.0".

@vladimirmujagic
Copy link

Thank you very much, it solved the issues. I was using released windows executable, works both on Linux and Windows when "building from source".

@KoltesDigital
Copy link
Owner

Sorry for being late again...

I finally took time to fix the CICD. As mentioned, the code was fixed months ago, but the CICD didn't actually published anything.

A working version is now available! https://github.com/KoltesDigital/shadertoy-exporter/releases/tag/1.5.4

But, well, this project is so old. Libraries are outdated, UI isn't friendly. If someone has time to take it over...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants