Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tracing For Additional Observability #45

Open
seanmalloy opened this issue Dec 9, 2021 · 2 comments
Open

Add Tracing For Additional Observability #45

seanmalloy opened this issue Dec 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@seanmalloy
Copy link
Contributor

What happens?

Currently the prometheus_bigquery_remote_storage_adapter application only supports logs and prometheus metrics for observability.

What were you expecting to happen?

I would like to be able to use tracing to monitor/observe prometheus_bigquery_remote_storage_adapter when running in a production environment.

Steps to reproduce:

Run prometheus_bigquery_remote_storage_adapter and notice that only logs and prometheus metrics are provided.

Any errors, stacktrace, logs?

N/A

Environment:

  • Runtime version(Java, Go, Python, etc): N/A
  • Desktop OS/version: N/A

Additional comments:

From my perspective it seems like OpenTelemetry would provide a nice vendor neutral option for enabling tracing.

@seanmalloy seanmalloy added the enhancement New feature or request label Dec 9, 2021
@wdoogz
Copy link
Contributor

wdoogz commented Feb 24, 2022

@seanmalloy were you thinking about offering tracing as a flag in our code when the application is started it'll begin sending the traces to a OTel collector (such as maybe another sidecar running within the same pod as the Prom BQ remote storage adapter), which will send it to whatever backend a user wishes?

@seanmalloy
Copy link
Contributor Author

@seanmalloy were you thinking about offering tracing as a flag in our code when the application is started it'll begin sending the traces to a OTel collector (such as maybe another sidecar running within the same pod as the Prom BQ remote storage adapter), which will send it to whatever backend a user wishes?

@wdoogz my simple answer is yes I agree with you.

I'm not an OpenTelemetry expert, but I think we would want to keep this feature as vendor agnostic as possible, so using the OpenTelemetry collector seems like a good idea.

https://opentelemetry.io/docs/collector/

Also, having a flag to enable/disable tracing seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants