Replace connect-gzip-static with express-static-gzip to become compatible with node 23. #24619
+83
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connect-gzip-static > 3 requires Node 20, but unfortunately we cannot upgrade due to nodejs/docker-node#1946 . I hope it will be fixed soon. |
|
Given that Node 18 is in maintenance until +- April 2025, we also need to support it until then (since that is the strategy z2m follows). Of course we also want to support Node 23. Therefore I think the best way forward is to remove this dependency, could you take a look into that?
|
Old versions of connect-gzip-static are not compatible with node 23, new versions of connect-gzip-static are not compatible with node 18, but we want to support both. express-static-gzip is compatible with all versions.
bdolgov
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a dependency on
@folder/readdirwhich is not compatible with node 23.Fixes #24568.