syslog logging broken in v1.39.0 ("undefined" messages)

[skazi0]

What happened?

After upgrading from v1.38.0 to v1.39.0 my syslog started logging "undefined" instead of messages:

lip 02 16:53:50 openhab systemd[1]: Started zigbee2mqtt.service - zigbee2mqtt.
lip 02 16:53:54 openhab npm[2613725]: > [email protected] start
lip 02 16:53:54 openhab npm[2613725]: > node index.js
lip 02 16:53:55 openhab npm[2613738]: Starting Zigbee2MQTT without watchdog.
lip 02 16:54:07 openhab Zigbee2MQTT[2613738]: undefined
lip 02 16:54:07 openhab Zigbee2MQTT[2613738]: undefined
lip 02 16:54:07 openhab Zigbee2MQTT[2613738]: undefined

in v1.38.0 it looks like this:

lip 02 17:05:00 openhab systemd[1]: Started zigbee2mqtt.service - zigbee2mqtt.
lip 02 17:05:04 openhab npm[2615727]: > [email protected] start
lip 02 17:05:04 openhab npm[2615727]: > node index.js
lip 02 17:05:17 openhab Zigbee2MQTT[2615805]: z2m: Logging to console (silenced), syslog
lip 02 17:05:17 openhab Zigbee2MQTT[2615805]: z2m: Starting Zigbee2MQTT version 1.38.0 (commit #fe048e6e)
lip 02 17:05:17 openhab Zigbee2MQTT[2615805]: z2m: Starting zigbee-herdsman (0.49.2)

What did you expect to happen?

Logging to syslog still works after upgrade.

How to reproduce it (minimal and precise)

with following config:

frontend:
  port: 8081
mqtt:
  base_topic: zigbee2mqtt
  server: mqtt://localhost
serial:
  port: /dev/ttyUSB0
devices:
(...)
advanced:
  log_output:
    - syslog
  log_syslog:
    path: /dev/log
    protocol: unix
    localhost: ''
availability:
  active:
    timeout: 10
  passive:
    timeout: 1500

running following commands:

$ cd /opt/zigbee2mqtt
$ git checkout 1.39.0 # or git checkout master
$ npm ci --no-audit --no-update-notifier
$ npm run build
$ sudo systemctl restart zigbee2mqtt
$ sudo journalctl -u zigbee2mqtt -f

Zigbee2MQTT version

1.39.0 or current master

Adapter firmware version

20230507

Adapter

ZBDongle-P

Setup

direct git checkout on debian12 VM with USB passthrough

Debug log

No response

[pcb1962]

I'm seeing the same:

Shutdown 1.38 and restart on 1.39:

Jul  2 01:11:52 hyena Zigbee2MQTT[7]: z2m:mqtt: MQTT publish: topic 'z2m/workshop/presence/z1a', payload '{"elapsed":91,"fading_time":10,"illuminance":1546,"indicator":"ON","large_motion_detection_distance":6.5,"large_motion_detection_se
nsitivity":7,"last_seen":1719879112784,"linkquality":98,"medium_motion_detection_distance":4.5,"medium_motion_detection_sensitivity":10,"motion_state":"medium","presence":true,"small_detection_distance":4.5,"small_detection_sensitivity":
10}'
Jul  2 01:11:52 hyena Zigbee2MQTT[7]: z2m:mqtt: MQTT publish: topic 'z2m/workshop/presence/z1a', payload '{"fading_time":10,"illuminance":1546,"indicator":"ON","large_motion_detection_distance":6.5,"large_motion_detection_sensitivity":7,
"last_seen":1719879112992,"linkquality":94,"medium_motion_detection_distance":4.5,"medium_motion_detection_sensitivity":10,"motion_state":"medium","presence":true,"small_detection_distance":4.5,"small_detection_sensitivity":10}'
Jul  2 01:11:55 hyena Zigbee2MQTT[7]: z2m:mqtt: Disconnecting from MQTT server
Jul  2 01:11:55 hyena Zigbee2MQTT[7]: z2m: Stopping zigbee-herdsman...
Jul  2 01:12:07 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:07 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:07 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:07 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:07 hyena Zigbee2MQTT[7]: undefined

Restart on 1.38:

Jul  2 01:12:49 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:49 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:49 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:12:49 hyena Zigbee2MQTT[7]: undefined
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: z2m: Logging to console (silenced), syslog
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: z2m: Starting Zigbee2MQTT version 1.38.0 (commit #fe048e6)
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: z2m: Starting zigbee-herdsman (0.49.2)
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: zh:zstack:znp: Opening TCP socket with zigbeecoord.pandasys.net:6638
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: zh:zstack:znp: Socket connected
Jul  2 01:13:01 hyena Zigbee2MQTT[7]: zh:zstack:znp: Socket ready

[Koenkk]

It's probably due to https://github.com/Koenkk/zigbee2mqtt/pull/22859/files#r1664658194, checking it.