Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement prettier #7702

Merged
merged 8 commits into from
Jun 29, 2024
Merged

fix: Implement prettier #7702

merged 8 commits into from
Jun 29, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jun 27, 2024

CC: @Nerivec

Repository owner deleted a comment from github-actions bot Jun 27, 2024
Repository owner deleted a comment from github-actions bot Jun 27, 2024
Repository owner deleted a comment from github-actions bot Jun 27, 2024
@Nerivec
Copy link
Contributor

Nerivec commented Jun 27, 2024

Well now, that's some cleanup job!

Probably should also enforce providing a reason for @ts-expect-error (ensure it's warranted).
Seems there are a lot of obj.hasOwnProperty('var') in here too, might want to change that to obj.var != undefined where appropriate (likely most of them).
Might want separate PRs though, to commit this faster to avoid too many conflicting PRs being opened in the meantime.

src/devices/ubisys.ts Outdated Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved
Repository owner deleted a comment from github-actions bot Jun 29, 2024
@Koenkk Koenkk merged commit 607a13e into master Jun 29, 2024
3 checks passed
@Koenkk Koenkk deleted the fix/prettier branch June 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants