Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): use legacyAction in modern extends to avoid problems from converter duplication #7376

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

mrskycriper
Copy link
Contributor

@mrskycriper mrskycriper commented Apr 9, 2024

This PR should prevent any problems from happening when legacy click was present next to modern extend.

Also partial fix Koenkk/zigbee2mqtt#22084 (yes, the 3rd one).

src/lib/modernExtend.ts Outdated Show resolved Hide resolved
@mrskycriper mrskycriper changed the title fix(legacy): use legacyClick in modern extends to avoid problems from dupication fix(legacy): use legacyAction in modern extends to avoid problems from dupication Apr 9, 2024
@mrskycriper mrskycriper changed the title fix(legacy): use legacyAction in modern extends to avoid problems from dupication fix(legacy): use legacyAction in modern extends to avoid problems from converter duplication Apr 9, 2024
@Koenkk Koenkk merged commit 6ce51f9 into Koenkk:master Apr 9, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IKEA Symfonisk Gen2 remotes E2123 not pairing after in 1.36.1-dev commit: 3e91349
2 participants