fix: Fix pairing of Legrand devices failing #7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tsc is not willing to build this Edit: nvm, I just needed to like my zh repo with the change before running |
|
With the way it is done now, I guess we could also move this to a modernExtend we attach to all legrand/biticino/netamo devices ? And if we move the Aqara feeder one too the onEvent in index.ts would not be needed. |
We cannot, since this happen before interview finishes (until interview finishes, it is not linked against a definition). Does the fix work? |
|
Ah good point! We need it during interviewing too! Yes, this code as is works. |
|
Great, will fix the tests and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Koenkk/zigbee-herdsman#982
Fixes Koenkk/zigbee-herdsman#979