VOCKQJK11LM Improvements and modernExtend conversion (2/4)

[sjorge]

Still very WIP but I though I'd open as draft already.

I plan on extending the modernExtend numeric with a 'calibration' argument that will toggle the calibration options.
It would be nice to have that code available for all numerics so we can easily enable where it makes sense.

[sjorge]

@Koenkk looks like somehow with the current code the options for temperature calibration are already somehow exposed. I don't understand where it's getting it from though. Do we just automatically add them for temperature ?

On the upside, seems the calibration is working fine with the changes so far! I

[Koenkk]

@sjorge I don't understand it either, but anyway the whole calibration should be moved up (outside of the converters)

[sjorge]

@sjorge I don't understand it either, but anyway the whole calibration should be moved up (outside of the converters)

Where do you want the calibration to end up ?

[Koenkk]

There should be some "post process" function (out of scope for this PR), thinking about it now, you can remove the whole calibrate from your code, since the calibrate options will be discovered automatically based on the exposes.

[sjorge]

There should be some "post process" function (out of scope for this PR), thinking about it now, you can remove the whole calibrate from your code, since the calibrate options will be discovered automatically based on the exposes.

Having a post process chain would be very nice, it could also fix things like fz.SNZB_temperature() as we can just add filter function to the chain.

So I just drop the calibrate stuff and the PR is good to go I guess ?

[sjorge]

Cleaned up the calibrate stuff.

[Koenkk]

Thanks!