Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger reporting to Discord causes fatal errors in KockaLogger #59

Open
KockaAdmiralac opened this issue Sep 9, 2023 · 0 comments
Open

Logger reporting to Discord causes fatal errors in KockaLogger #59

KockaAdmiralac opened this issue Sep 9, 2023 · 0 comments
Assignees
@KockaAdmiralac
Labels
bug Something isn't working

Comments

@KockaAdmiralac
Copy link
Owner

Description

The logger's logging methods are technically asynchronous, but no component of the system calls them as such. This means Discord backend errors can cause KockaLogger to crash due to uncaught promise rejections.

Reproduction steps

Steps to reproduce the behavior:

  1. Wait for Discord backend to get unstable
  2. Get KockaLogger to report an error at that time
  3. See how it crashes and restarts

Expected behavior

It doesn't crash.
@KockaAdmiralac KockaAdmiralac added the bug Something isn't working label Sep 9, 2023
@KockaAdmiralac KockaAdmiralac self-assigned this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KockaAdmiralac KockaAdmiralac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KockaAdmiralac