-
-
Notifications
You must be signed in to change notification settings - Fork 600
Fix call to test a webhook method #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Interesting. Are you calling this from a "GitHub app" or an "OAuth app". Do you know what version of GitHub Enterprise supports the new endpoint. Changing this could break things for those users. |
The result was the same for both GithubApp and oAuth App.
I don’t have GitHub enterprise so can’t comment on that.
…On Sun, 2 Aug 2020 at 22:35, Graham Campbell ***@***.***> wrote:
Interesting. Are you calling this from a "GitHub app" or an "OAuth app".
Do you know what version of GitHub Enterprise supports the new endpoint.
Changing this could break things for those users.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#915 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQRX75VNYKQ72J3OQVX4LR6XL3DANCNFSM4PSU4EIA>
.
|
I think we can safely apply this change, as in the github enterprise 2.18 docs the endpoint url is also like the note indicates {
"/repos/{owner}/{repo}/hooks/{hook_id}/tests":{
"post":{
"summary":"Test the push repository webhook",
"description":"This will trigger the hook with the latest push to the current repository if the hook is subscribed to `push` events. If the hook is not subscribed to `push` events, the server will respond with 204 but no test POST will be generated.\n\n**Note**: Previously `/repos/:owner/:repo/hooks/:hook_id/test`",
"tags":[
"repos"
],
"operationId":"repos/test-push-webhook",
"externalDocs":{
"description":"API method documentation",
"url":"https://developer.github.com/enterprise/2.18/v3/repos/hooks/#test-the-push-repository-webhook"
},
"parameters":[
{
"$ref":"#/components/parameters/owner"
},
{
"$ref":"#/components/parameters/repo"
},
{
"$ref":"#/components/parameters/hook-id"
}
],
"responses":{
"204":{
"description":"Empty response"
},
"404":{
"$ref":"#/components/responses/not_found"
}
},
"x-github":{
"githubCloudOnly":false,
"enabledForGitHubApps":true,
"previews":[
]
}
}
}
} What do you think @GrahamCampbell? |
Thanks @morrislaptop! And congrats on your first contribution! 🎉 |
* 2.x: Fix bc break in check api class Switch CI setup from travisci to github actions Adding GitHub authentication to GraphQL documentation bug #915 Fix call to test a webhook method (morrislaptop) Remove antiope preview header as checks api is now stable
See renamed URL in the note at https://docs.github.com/en/rest/reference/repos#test-the-push-repository-webhook
Using old URL gives an error "Resource not accessible by integration"