Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added phpstan #871

Merged
merged 7 commits into from
May 7, 2020
Merged

Added phpstan #871

merged 7 commits into from
May 7, 2020

Conversation

clxkoders
Copy link
Contributor

@clxkoders clxkoders commented May 7, 2020 •
edited
Loading

closes #857

acrobat
acrobat requested changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @clxkoders! Only a few comments

.travis.yml Outdated Show resolved Hide resolved
phpstan-baseline.neon Outdated Show resolved Hide resolved
@acrobat acrobat merged commit f2abf32 into KnpLabs:master May 7, 2020
@acrobat
Copy link
Collaborator

acrobat commented May 7, 2020

Thank you @clxkoders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

@staabm staabm staabm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phpstan coverage
3 participants
@clxkoders @acrobat @staabm