-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated Organization\Teams api calls #860
Conversation
- \Github\Api\Organization\Teams::show - \Github\Api\Organization\Teams::update - \Github\Api\Organization\Teams::remove - \Github\Api\Organization\Teams::members - \Github\Api\Organization\Teams::check - \Github\Api\Organization\Teams::addMember - \Github\Api\Organization\Teams::removeMember
we could add the organization as a optional argument, and also adjust the implementation to be BC compatibel, e.g. instead of
use
|
Don't worry about StyleCI. Its fixes will be automatically applied when the PR is merged (assuming the package author has enabled that option). |
@staabm I've changed it to your suggested way but keep in mind that in a next version, the $organization should be set as required since the api calls don't work without an organization set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lolos Thanks for the PR, it already looks good! Just one comment about the current setup.
Thanks @lolos! And congrats on your first contribution! 🎉 |
This Pull Request fixes the API calls for the functions:
based on the official Github's v3 API documentation:
since those functions incorrectly threw
Github\Exception\RuntimeException: Not Found